Skip to content

Dialect-aware DELETE-query rendering & DELETE LIMIT support#20

Merged
ez-plugins merged 4 commits intomainfrom
feature/delete-from
Apr 18, 2026
Merged

Dialect-aware DELETE-query rendering & DELETE LIMIT support#20
ez-plugins merged 4 commits intomainfrom
feature/delete-from

Conversation

@ez-plugins
Copy link
Copy Markdown
Contributor

Features

  • Dialect-aware DELETE rendering - SqlDialect now exposes a renderDelete(Query) method that generates
    a fully dialect-aware DELETE FROM … WHERE … statement, including proper identifier quoting per dialect.

Improvements

  • MySQL DELETE … LIMIT - MySqlDialect now appends a LIMIT clause to DELETE statements when a limit
    is set on the query.
  • SQLite DELETE … LIMIT - SqliteDialect does the same; standard dialect silently ignores limit on
    DELETE to remain ANSI-compliant.
  • appendWhereClause and appendConditionFragment in AbstractSqlDialect promoted to protected so
    subclasses can reuse the shared WHERE rendering logic.

Tests

  • Added AbstractSqlDialectDeleteTest covering parameter parity with render(), identifier quoting,
    LIMIT behaviour across all three dialects, and IN placeholder generation.

Chores

  • Version bumped to 1.0.4
  • README updated: dialect comparison table now includes a DELETE LIMIT column; new
    Dialect-aware DELETE rendering subsection with code examples for all three dialects.

@EzFramework EzFramework deleted a comment from github-actions bot Apr 18, 2026
@EzFramework EzFramework deleted a comment from github-actions bot Apr 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 18, 2026

Test Results

136 tests  +3   136 ✅ +3   0s ⏱️ ±0s
 20 suites +1     0 💤 ±0 
 20 files   +1     0 ❌ ±0 

Results for commit 6e2c34d. ± Comparison against base commit 410507e.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@ez-plugins ez-plugins merged commit 348706c into main Apr 18, 2026
7 checks passed
@ez-plugins ez-plugins deleted the feature/delete-from branch April 18, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant