Fix mypy arg-type error in test_line_collection.py#55
Merged
ErwindeGelder merged 1 commit intoErwindeGelder:mainfrom Mar 23, 2026
Merged
Fix mypy arg-type error in test_line_collection.py#55ErwindeGelder merged 1 commit intoErwindeGelder:mainfrom
ErwindeGelder merged 1 commit intoErwindeGelder:mainfrom
Conversation
Wrap np.amin()/np.amax() calls in float() to fix arg-type error when passing numpy scalar types to set_xlim()/set_ylim().
krishna-ji
force-pushed
the
fix/mypy-errors
branch
from
f744ac4 to
35bbff4
Compare
krishna-ji
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps
np.amin()/np.amax()calls infloat()intest_line_collection.pyto fix a mypyarg-typeerror when passing numpy scalar types toset_xlim()/set_ylim().All checks pass:
tox -e lint,py314(ruff format, ruff check, mypy, 113/113 tests).