Test cases for AutomationRegistry and related contracts#30
Test cases for AutomationRegistry and related contracts#30udityadav-supraoracles wants to merge 6 commits into
Conversation
| if (_taskIndexes.length == 0) { return; } | ||
|
|
There was a problem hiding this comment.
Why is this removed? Perhaps there might be some work required even when _taskIndexes.length==0 but are you sure this check is not needed? @udityadav-supraoracles
There was a problem hiding this comment.
Since this was common, I've moved it to here: https://github.com/Entropy-Foundation/revm/pull/30/changes#diff-717de60a807d254508ac043ac65fb7d0b6adf40894ad5f49c70b8808d545f81cR29
| if (_taskIndexes.length == 0) { return; } | ||
|
|
There was a problem hiding this comment.
Same question @udityadav-supraoracles
There was a problem hiding this comment.
Since this was common, I've moved it to here: https://github.com/Entropy-Foundation/revm/pull/30/changes#diff-717de60a807d254508ac043ac65fb7d0b6adf40894ad5f49c70b8808d545f81cR29
| ICoreFacet(diamondAddr).processTasks(index, tasks); | ||
| } | ||
|
|
||
| /// @notice Test to ensure 'processTasks' reverts if tasks are processed out of order. |
There was a problem hiding this comment.
order is based on priority here or task_index? @udityadav-supraoracles @aregng
There was a problem hiding this comment.
It is based on taskIndex.
if (expectedTask != _taskIndex) { revert ICoreFacet.OutOfOrderTaskProcessingRequest(); }
2 participants
This PR includes test cases for AutomationRegistry and other related contracts.