feat(cli): add version check to studio/serve commands#1131
Merged
Conversation
Enforce `required_version` from `.agentv/config.yaml` before starting Studio so the dashboard matches `agentv eval` behavior. Interactive TTY prompts to update; non-interactive warns to stderr and continues. Closes #1128
Deploying agentv with
|
| Latest commit: |
f78f824
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://567e0b5e.agentv.pages.dev |
| Branch Preview URL: | https://feat-1128-version-check-stud.agentv.pages.dev |
Address review feedback: reflect the new startup-time version enforcement in the module's header JSDoc, and reword the inline comment to describe the multi-project limitation without referencing an external issue number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required_versionfrom.agentv/config.yamlbefore starting AgentV Studio (agentv studio/agentv serve), matching the existingagentv evalbehavior.Implementation
apps/cli/src/commands/results/serve.ts— callenforceRequiredVersion()(fromversion-check.ts) before the server is started, usingloadConfig()+findRepoRoot()to locate the project's.agentv/config.yaml(same pattern asrun-eval.ts:988-992).The check runs after benchmark-management subcommands (
--add/--remove/--discover) so those paths aren't affected.Red/Green UAT
Red (on
main):agentv studiowith a mismatchedrequired_version: ">=99.0.0"launched silently — no warning, no prompt. Output:Green (this branch):
Non-interactive (stdin redirected) with
required_version: ">=99.0.0":Server starts normally after the warning.
Interactive TTY (via
script), user answersn:User declines; server starts as before.
Satisfying range (
required_version: ">=4.0.0"): no warning, no prompt — server starts silently.No
.agentv/config.yaml: no warning, server starts silently.Test plan
Closes #1128