chore: share agent slash commands#63
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPoints ChangesAgent Command Centralization
Release Workflow Enhancements
Sequence DiagramsequenceDiagram
actor Actions as GitHub Actions
participant App as GitHub App
participant Checkout as actions/checkout
participant ReleaseStep as release-plz Release PR
participant Parser as jq
participant GH as gh CLI
participant GitHub as GitHub API
Actions->>App: request App token
App-->>Actions: return token
Actions->>Checkout: checkout repo @ commit SHA (token if provided)
Checkout-->>Actions: repo contents
Actions->>ReleaseStep: run Release PR step
ReleaseStep-->>Actions: outputs (prs JSON, prs_created)
Note right of Actions: if prs_created == 'true'
Actions->>Parser: parse steps.release-pr.outputs.prs (extract .number)
Parser-->>Actions: pr_number
Actions->>GH: set GH_TOKEN and run gh pr update-branch pr_number --rebase
GH->>GitHub: request rebase/update branch
GitHub-->>GH: result
GH-->>Actions: result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes correctly implement shared agent command definitions by relocating them to .agents/commands and creating a symlink for Claude compatibility. The workflow updates properly add branch specification and automated rebase functionality, and the documentation clearly describes the command lookup mechanism. All changes are functional and ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/release-plz.yml (1)
91-106: 💤 Low valueRemove unused
head_branchvariable or clarify intent.The
head_branchis extracted and validated on lines 100-101 but never used—onlypr_numberis passed togh pr update-branch. The variable either represents defensive programming or dead code that should be removed for clarity.Note: For mono-repos with multiple PRs, the
proutput is designed to provide the first PR object only. The code will not fail with jq parsing, but it will only rebase the first PR. If all release PRs require rebasing, consider using theprsoutput (array) instead and looping through each PR.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release-plz.yml around lines 91 - 106, The script extracts head_branch via "head_branch=$(jq -r '.head_branch // empty' <<<"$PR')" and checks it but never uses it; remove that extraction and its emptiness check and only validate pr_number (the jq extraction for pr_number and the gh pr update-branch "$pr_number" call remain), or if the intent was to rebase multiple PRs switch to using the "prs" array output and loop over each PR object instead of relying on a single "pr" object; update the jq/validation logic accordingly and remove the dead head_branch variable and related conditional.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 20-21: The AGENTS.md text incorrectly calls `.claude/commands` a
"symlink" while the repo uses a plain text file; either make `.claude/commands`
an actual filesystem symlink pointing to the shared command definitions
(preferred) or update AGENTS.md to say it is a text file that contains the path
to the shared commands. Locate the `.claude/commands` artifact and either
replace it with a symlink to the shared commands target or change the wording in
AGENTS.md to "text file containing a path reference" and keep the documented
command lookup/path details unchanged.
---
Nitpick comments:
In @.github/workflows/release-plz.yml:
- Around line 91-106: The script extracts head_branch via "head_branch=$(jq -r
'.head_branch // empty' <<<"$PR')" and checks it but never uses it; remove that
extraction and its emptiness check and only validate pr_number (the jq
extraction for pr_number and the gh pr update-branch "$pr_number" call remain),
or if the intent was to rebase multiple PRs switch to using the "prs" array
output and loop over each PR object instead of relying on a single "pr" object;
update the jq/validation logic accordingly and remove the dead head_branch
variable and related conditional.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c10a7bd3-8e4d-4164-ae96-e6c18f69c1fe
📒 Files selected for processing (8)
.agents/commands/address-pr-feedback.md.agents/commands/commit.md.agents/commands/handoff.md.agents/commands/pr.md.agents/commands/review.md.claude/commands.github/workflows/release-plz.ymlAGENTS.md
Signed-off-by: Brad Anderson <brad@enforceauth.com>
boorad
force-pushed
the
chore/shared-agent-commands
branch
from
268a841 to
8b246cf
Compare
|
@coderabbitai Addressed review-body nitpick in de308b4: removed the unused |
|
Tip For best results, initiate chat on the files or code changes.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release-plz.yml:
- Line 31: The workflow pins the checkout to a moving branch head ("ref: main")
which can run against a different commit than the event that triggered the run;
replace both occurrences of "ref: main" in the release-plz.yml checkout steps
with the triggering commit SHA (use the GitHub context, e.g. the
github.sha/event SHA) so the checkout uses the exact commit that started the
workflow (update the two "ref: main" instances referenced in the checkout
steps).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 62d49528-5fdf-48d7-af47-5702e1039297
📒 Files selected for processing (1)
.github/workflows/release-plz.yml
1 participant
Summary
.claude/commandsto.agents/commands.claude/commandswith a symlink for Claude compatibilityAGENTS.mdTesting
cargo checkcargo clippy -- -D warningscargo fmt --checkcargo testactionlint .github/workflows/release-plz.ymlSummary by CodeRabbit
Documentation
Chores