[NO MERGE] optimize fee estimation test, re-include in regular list#564
Open
instagibbs wants to merge 1 commit intoElementsProject:masterfrom
Open
[NO MERGE] optimize fee estimation test, re-include in regular list#564instagibbs wants to merge 1 commit intoElementsProject:masterfrom
instagibbs wants to merge 1 commit intoElementsProject:masterfrom
Conversation
Contributor
Author
|
Actually seems to work reasonably. Test took under 500 seconds, and whole suite in about 44 minutes. |
Contributor
Author
|
It's passing consistently. Restarting one more time, @stevenroose could you ACK/merge if it passes again? |
Contributor
Author
|
interesting, the section where it's supposed to recover in a few seconds failed to. Timed out at this section: One mempool was missing a tx to the end of the test. Wonder what happened there... leaving this PR open then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning off mempool consistency checks sped up this test by 30%.