Fix TatumScanAdapter pagination fields and deduplicate cleaner#17
Draft
cursor[bot] wants to merge 2 commits intofeature/tatum-pluginfrom
Draft
Fix TatumScanAdapter pagination fields and deduplicate cleaner#17cursor[bot] wants to merge 2 commits intofeature/tatum-pluginfrom
cursor[bot] wants to merge 2 commits intofeature/tatum-pluginfrom
Conversation
We need dependable address activity detection on chains where existing providers were missing coverage or produced inconsistent updates in production. Using Tatum as the common integration point reduces monitoring blind spots and makes webhook event handling more reliable under real-world delivery behavior.
…tion - Make prevPage and nextPage optional in asTatumTransactionsResponse - Extract shared cleaner to prevent inconsistencies between implementations - Import asOptional in TatumScanAdapter.ts Fixes: - Bug 8ac467b9: TatumScanAdapter now handles chains without cursor pagination - Bug 95a29670: Eliminated duplicated Tatum scan logic cleaner
2 tasks
samholmes
force-pushed
the
feature/tatum-plugin
branch
from
36238f5 to
07fb99d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
This PR fixes two bugs in the TatumScanAdapter:
Made pagination fields optional: The
prevPageandnextPagefields inasTatumTransactionsResponseare now properly marked as optional usingasOptional(asString). These cursor-based pagination fields are only present for certain chains (e.g., Tezos) and are absent for Ethereum Classic, which uses offset-based pagination. Without this fix, the cleaner would throw on every scan request for Ethereum Classic.Eliminated duplicated cleaner definition: Extracted the
asTatumTransactionsResponsecleaner to a shared export inTatumScanAdapter.tsand imported it intatum.ts. This prevents future inconsistencies between the two implementations.Changes:
asOptionalto imports inTatumScanAdapter.tsprevPageandnextPagefromasStringtoasOptional(asString)in the cleanerasTatumTransactionsResponsefromTatumScanAdapter.tstatum.tsand imported the shared oneAll tests pass and the Tatum scan adapter is now functional for Ethereum Classic.