Open
Conversation
When data objects are pickled and then unpickled on a different system, Paths can lead to errors, because PosixPaths can't be created non Windows machines, and WindowsPaths can't be created on Posix machines. This commit replaces Paths in EITData with PurePaths. These are either PurePosixPaths or PureWindowsPaths, both of which can be handled on all machines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When data objects containing paths are pickled and then unpickled on a different system, Paths can lead to errors, because PosixPaths can't be created non Windows machines, and WindowsPaths can't be created on Posix machines.
This PR replaces Paths in EITData with PurePaths. These are either PurePosixPaths or PureWindowsPaths, both of which can be handled on all machines. Only when the PurePaths are used for interacting with files (e.g., opening, getting the file size, etc.) they are converted to Paths.