Make allocation of cpus and threads dynamic#437
Draft
mpaiao wants to merge 2 commits into
Draft
Conversation
This is an attempt to fix issue #436. Instead of hard coding the number of threads and cpus, we allocate them based on the information retrieved by the intrinsic functions.
xiangtaoxu
approved these changes
Jun 12, 2026
|
Don't merge this yet. It initializes thread_use and cpu_use before they are allocated, so OMP-enabled runs will crash. |
Contributor
Author
|
Thanks @LMurphy186232! I made this very hastily, and it indeed needs testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to fix issue #436. Instead of hard coding the number of threads and cpus, we allocate them based on the information retrieved by the intrinsic functions.
Collaborators
@LMurphy186232 who identified the problem
@xiangtaoxu who provided initial feedback
Types of changes
Changes in Settings, Input Files or Output Files
Expectation of Answer Changes:
Bit-for-bit compatibility when the number of cpus and number of threads is less than 64. Otherwise, this (hopefully) allows the code to run.
Checklist:
Testing :