feat(fcntl): implement F_SETSIG/F_GETSIG#1880
Open
jiuyue486 wants to merge 2 commits intoDragonOS-Community:masterfrom
Open
feat(fcntl): implement F_SETSIG/F_GETSIG#1880jiuyue486 wants to merge 2 commits intoDragonOS-Community:masterfrom
jiuyue486 wants to merge 2 commits intoDragonOS-Community:masterfrom
Conversation
Implement the F_SETSIG/F_GETSIG fcntl commands so userspace can pick the signal delivered for asynchronous I/O notifications. arg == 0 keeps the SIGIO default; values in (0, SIGRTMAX] override it. - Add a per-File `fasync_signum` (AtomicI32), preserved across `try_clone`. - Validate the raw `usize` arg against `SIGRTMAX` to avoid 64-bit values whose low 32 bits accidentally fall in [0, SIGRTMAX] from being silently accepted. Look up the fd first so EBADF wins over EINVAL, matching Linux `fs/fcntl.c`. - Cover defaults, set/get round-trip, the SIGRTMAX boundary, invalid values, and invalid fd in a new `fcntl_signal` dunitest.
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the F_SETSIG/F_GETSIG fcntl commands so userspace can pick
the signal delivered for asynchronous I/O notifications. arg == 0
keeps the SIGIO default; values in (0, SIGRTMAX] override it.
fasync_signum(AtomicI32), preserved acrosstry_clone.usizearg againstSIGRTMAXto avoid 64-bitvalues whose low 32 bits accidentally fall in [0, SIGRTMAX] from
being silently accepted. Look up the fd first so EBADF wins over
EINVAL, matching Linux
fs/fcntl.c.values, and invalid fd in a new
fcntl_signaldunitest.