fix: prevent table misalignment for redacted tokens#533
Open
yutak03 wants to merge 1 commit intoDopplerHQ:masterfrom
Open
fix: prevent table misalignment for redacted tokens#533yutak03 wants to merge 1 commit intoDopplerHQ:masterfrom
yutak03 wants to merge 1 commit intoDopplerHQ:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the Unicode ellipsis (
…) used in redacted auth tokens with ASCII....Why
Redacted auth tokens are displayed in table output, for example in
doppler configure --all.The Unicode ellipsis character can have ambiguous display width depending on the terminal and font environment. In terminals where it is rendered with a width different from what the table formatter expects, table borders can become misaligned.
I observed the misalignment in:
I did not observe the issue in:
Using ASCII
...avoids ambiguous character width behavior and keeps table alignment stable across terminal environments.Before
In affected terminals, this can cause the table border to shift by one column.
After
Screenshots
Before, in iTerm2:
After, in iTerm2:
Testing
make buildmake test