Skip to content

Components v1.0#2924

Merged
corsacca merged 1 commit into
DiscipleTools:developfrom
cairocoder01:components-v1_0
Jun 17, 2026
Merged

Components v1.0#2924
corsacca merged 1 commit into
DiscipleTools:developfrom
cairocoder01:components-v1_0

Conversation

@cairocoder01

Copy link
Copy Markdown
Collaborator
  • Resolve Firefox church circle positioning bug
  • Add readonly property to DtFormBase and all extending components.
  • Components display values statically in readonly mode, with a toggle to enable editing.
  • Enhance ComponentService to centralize geocoding API integration for location components.
  • Update @disciple.tools/web-components to 1.0.0.

* Resolve Firefox church circle positioning bug
* Add `readonly` property to `DtFormBase` and all extending components.
* Components display values statically in `readonly` mode, with a toggle to enable editing.
* Enhance `ComponentService` to centralize geocoding API integration for location components.
* Update `@disciple.tools/web-components` to `1.0.0`.
@github-actions

Copy link
Copy Markdown

Code Review

Scope: @disciple.tools/web-components bump from ^0.9.2 to ^1.0.0, updated build artifacts.

High

No high-severity issues found.

Medium

No medium-severity issues found.

Notes (no action required)

API compatibility verified: The ComponentService constructor signature is unchanged — (postType, postId, nonce, apiRoot="wp-json"). All call sites in details.js, new-record.js, merge-post-details.js, and settings.js remain compatible. Static methods convertValue, convertApiValue, and valueArrayDiff are all still present in the new build.

readonly is additive: The new readonly property on DtFormBase is independent of the existing disabled attribute. PHP rendering in dt-components.php:75 still uses disabled and will continue to work unchanged. readonly is available for future PHP opt-in.

dt-location without geocoding tokens is correct: render_location renders <dt-location> without mapbox-token/google-token attributes intentionally, since dt-location searches the DT location database via REST API through ComponentService.handleGetDataEvent. Only dt-location-map uses external geocoding and already receives both tokens in render_location_meta (dt-components.php:210-211).

index.es.js chunk reference change is harmless: The renamed chunk hash (index-wqGuHN5u.js) is expected after a rebuild. WordPress loads index.js (the IIFE/UMD bundle) directly — the ES module variant is for npm consumers, not WordPress.


Summary: PR looks ready to merge. All existing ComponentService call sites remain compatible, the readonly feature is properly additive, and the Firefox church-circle positioning fix and geocoding centralization are self-contained within the package.

@corsacca corsacca merged commit 6acb4d0 into DiscipleTools:develop Jun 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants