Retroactive review: wrapper fix and remaining changes#1
Retroactive review: wrapper fix and remaining changes#1
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf14af3e0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r"C:\Windows\Logs", | ||
| r"C:\Windows\Temp", | ||
| r"C:\Users\YourUser\AppData\Local\Temp" | ||
| r"C:\Users\Diego Chavez\AppData\Local\Temp" |
There was a problem hiding this comment.
Keep temp directory path user-agnostic
Replacing the generic user temp path with C:\Users\Diego Chavez\AppData\Local\Temp makes the default cleanup list machine-specific. On any Windows install where the username is not exactly Diego Chavez, this directory does not exist and optimizeStorage skips that target, so one of the three primary cleanup locations is silently not cleaned for most users.
Useful? React with 👍 / 👎.
This PR is a retroactive review branch containing the two already-pushed changes:
Conversation: https://app.warp.dev/conversation/2d426a2b-b183-4677-bd05-3f7f555a2b34
Co-Authored-By: Oz oz-agent@warp.dev