Fix: CalculatorSkill NPE when scoring operators in generateOutput#417
Merged
Conversation
standardMatchHelper is set to null after skill scoring completes, but CalculatorSkill.getOperation() calls operatorSection.score() during generateOutput, which requires a MatchHelper. Add a score(MatchHelper, String) overload to StandardRecognizerData so callers can provide their own MatchHelper. CalculatorSkill now creates a local MatchHelper for the operator text being matched.
Verifies that score() works with an explicit MatchHelper, which is needed when skills call score() during generateOutput where ctx.standardMatchHelper is null.
Stypox
approved these changes
May 13, 2026
Collaborator
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Thank you!
I guess it would be great to somehow write a test for each skill, that tests the whole evaluation infrastructure with just that skill and makes sure the right thing happens. But this is for the future.
Comment on lines
+24
to
+25
| val helper = MatchHelper(ctx.parserFormatter, text) | ||
| val (score, result) = operatorSection.score(helper, text) |
Collaborator
There was a problem hiding this comment.
I guess this makes sense anyway, it was using a helper set up with the wrong text earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
standardMatchHelper is set to null after skill scoring completes, but CalculatorSkill.getOperation() calls operatorSection.score() during generateOutput, which requires a MatchHelper.
Add a score(MatchHelper, String) overload to StandardRecognizerData so callers can provide their own MatchHelper. CalculatorSkill now creates a local MatchHelper for the operator text being matched.