test(frontend): reduce scope and increase mocking in slow test#1056
Merged
JamesDoingStuff merged 1 commit intomainfrom Nov 28, 2025
Merged
test(frontend): reduce scope and increase mocking in slow test#1056JamesDoingStuff merged 1 commit intomainfrom
JamesDoingStuff merged 1 commit intomainfrom
Conversation
JamesDoingStuff
requested review from
TBThomas56,
VictoriaBeilsten-Edmands and
davehadley
TBThomas56
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
WorkflowsListView > passes the mock workflows query data to the workflow listtest will start timing out in the CI once @TBThomas56's frontend linter changes are implemented. Not sure why - locally, the old test took ~ 0.6sThis adds more mocks and reduces the number of checks in the test so that it will pass (the changes were tested here - the failure is from another test)