Redirect

[1egoman]

Add a helper that can be used for redirecting to a different route.

The dashboard uses a pattern similar to this already, though I'm not completely sold on it since this change effectively adds the ability for an action creator that returns nothing (like the redirect action creator) to be a side-effect only action creator and I'm not sure if that's starting down a path of making this project too all-encompassing.

import createRouter, { redirect } from '@density/conduit';

const router = createRouter(store);
router.addRoute('foo/bar', redirect('hello/world'));
router.addRoute('hello/world', () => ({type: "NAVIGATE_TO_HELLO_WORLD"}) );

[guscost]

Looks good but the documentation probably has an error.

[guscost]

Is this being imported directly from the conduit package? Should probably document that if so.

[guscost]

RE: side-effect-only action creator: I'd suggest that this shouldn't be used for hash routes, the normal router navigate is what to use there.

Considering that redirects would/should be going to entirely different web apps, the side effect is really "finish interacting with the app" as far as the app itself is concerned.

[1egoman]

In one way that the dashboard currently uses this functionality, it's going to a different route in the dashboard, not to an external app: https://github.com/DensityCo/dashboard/blob/trunk/src/index.js#L137

But other than for deprecated routes like that (and we probably can get rid of that line now anyway) I agree.

[guscost]

Why can't that be () => router.navigate('spaces/insights') ?

[1egoman]

Because that function returns undefined, this breaks. Currently the redirect implementation in the dashboard is pretty much that only it returns a "dummy" action to get around that issue.

[guscost]

Ah, makes sense.