Added DMS_fnc_TargetsKilledPercent function, to check % of alive bots

[Ravenger2709]

Added DMS_fnc_TargetsKilledPercent function, to check alive bots and if count >= value in DMS_AI_KillPercent - go nect to playerNear condition and finish mission

Changed bandit.sqf mission to demonstrate function working.

Change DMS_fnc_MissionSuccessState function to work with new condition.

[Ravenger2709]

Fixed, tested with DMS_AI_KillPercent = 50
Work properly now

[eraser1]

Using a global variable to record the initial count only works if there is a single mission, or the same number of initial AI for each mission.

I'm not sure there's an easy way to resolve this without modifying the mission itself. I think it would be easiest to have the threshold calculated by the mission, and then pass the threshold as an additional parameter to fn_TargetsKilledPeecent.

[Ravenger2709]

I have an error

19:24:48 Error in expression <pletionArgs];
throw "ERROR";
};
};

if (_success && {_absoluteWinCondition}) the>
19:24:48 Error position: <_success && {_absoluteWinCondition}) the>
19:24:48 Error Undefined variable in expression: _success
19:24:48 File x\addons\dms\scripts\fn_MissionSuccessState.sqf..., line 77
19:24:48 Error in expression <on = _x param [2, false, [true]];

if (!_success && {!_absoluteWinCondition}) th>
19:24:48 Error position: <_success && {!_absoluteWinCondition}) th>
19:24:48 Error Undefined variable in expression: _success
19:24:48 File x\addons\dms\scripts\fn_MissionSuccessState.sqf..., line 40
19:24:48 Error in expression <t);
};

case "playernear":
{
_success = _success && (_completionArgs call DMS_fn>
19:24:48 Error position: <_success && (_completionArgs call DMS_fn>
19:24:48 Error Undefined variable in expression: _success
19:24:48 File x\addons\dms\scripts\fn_MissionSuccessState.sqf..., line 64
19:24:48 Error in expression <pletionArgs];
throw "ERROR";
};
};

if (_success && {_absoluteWinCondition}) the>
19:24:48 Error position: <_success && {_absoluteWinCondition}) the>
19:24:48 Error Undefined variable in expression: _success
19:24:48 File x\addons\dms\scripts\fn_MissionSuccessState.sqf..., line 77
19:24:48 Error in expression <S_fnc_DebugLog;
};
};
} forEach _this;

_success;
}>
19:24:48 Error position: <_success;
}>
19:24:48 Error Undefined variable in expression: _success
19:24:48 File x\addons\dms\scripts\fn_MissionSuccessState.sqf..., line 92

But have no idea how to fix it now. Do u know da way?

[Ravenger2709]

I found the decision, need more time to test

[Ravenger2709]

Have some issue with Initial unit count and Total living units

This result then mission starts.

Bots count in mission

_AICount = (5 + (round (random 4)));

12:28:56 "DMS DEBUG :: Kill percent value: 50"
12:28:56 "DMS DEBUG :: Initial unit count: 6"
12:28:56 "DMS DEBUG :: Units threshold (killed units): 3"
12:28:56 "DMS DEBUG :: Total living units: 10"
12:28:56 "DMS DEBUG :: Total killed units: 0"
12:28:56 "DMS DEBUG :: Kill percent condition not met"

After killing 3 bots

12:29:56 "DMS DEBUG :: Kill percent value: 50"
12:29:56 "DMS DEBUG :: Initial unit count: 6"
12:29:56 "DMS DEBUG :: Units threshold (killed units): 3"
12:29:56 "DMS DEBUG :: Total living units: 7"
12:29:56 "DMS DEBUG :: Total killed units: 0"
12:29:56 "DMS DEBUG :: Kill percent condition not met"

Now Total living units = Initial unit count
Killing 3 more bots...

Result

12:30:56 "DMS DEBUG :: Kill percent value: 50"
12:30:56 "DMS DEBUG :: Initial unit count: 6"
12:30:56 "DMS DEBUG :: Units threshold (killed units): 3"
12:30:56 "DMS DEBUG :: Total living units: 4"
12:30:56 "DMS DEBUG :: Total killed units: 2"
12:30:56 "DMS DEBUG :: Kill percent condition not met"

Killing one more

12:32:11 "DMS DEBUG :: Kill percent value: 50"
12:32:11 "DMS DEBUG :: Initial unit count: 6"
12:32:11 "DMS DEBUG :: Units threshold (killed units): 3"
12:32:11 "DMS DEBUG :: Total living units: 3"
12:32:11 "DMS DEBUG :: Total killed units: 3"
12:32:11 "DMS DEBUG :: Kill percent condition met"

It`s work almost fine, but i think that need some fix here

If i use _AICount = 5 ; instead _AICount = (5 + (round (random 4))); Total living units > Initial unit count too.

What do you think about this?

[Ravenger2709]

Solved

[Ravenger2709]

Hey! How are you?

[eraser1]

I'm going to be honest, I don't have the time nor desire to review this properly.

If you find somebody competent to review this and they say that it's good, I'll merge it.

The onus is on you to find somebody competent.

[Ravenger2709]

Thx for honest answer!