Bulk delete findings: extension hook and optional caller context#14740
Draft
valentijnscholten wants to merge 4 commits intoDefectDojo:devfrom
Draft
Bulk delete findings: extension hook and optional caller context#14740valentijnscholten wants to merge 4 commits intoDefectDojo:devfrom
valentijnscholten wants to merge 4 commits intoDefectDojo:devfrom
Conversation
- Split internal bulk delete implementation from entry point that can delegate via get_custom_method(BULK_DELETE_FINDINGS_METHOD). - Allow callers to pass optional cascade_root alongside chunk_size for downstream use when a custom method is configured.
- Extend bulk_delete_findings entry point with optional product_id for custom methods. - async_delete_task: resolve product once for grading and metering; pass product_id to bulk_delete_findings; skip perform_product_grading when deleting a Product.
Maffooch
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change reorganizes the bulk finding delete path so downstream projects (e.g. DefectDojo Pro) can plug in a custom implementation via the existing
get_custom_methodpattern, without altering the default OSS behavior.