add missing pem metrics for qfx5220 and ex4300#9
Conversation
| func (c *environmentCollector) Collect(client collector.Client, ch chan<- prometheus.Metric, labelValues []string) error { | ||
| c.environmentItems(client, ch, labelValues) | ||
| c.environmentPEMItems(client, ch, labelValues) | ||
| var v showVersionResult |
There was a problem hiding this comment.
Please extract version determination into a separate function. I'm wondering if no other place exists, that needs this already?
There was a problem hiding this comment.
Will put it into a separate function now. Not sure what is a good way to check if something like this is already done in the project, but fast look through pkg/.... didn't find any other usage of show version
| } | ||
|
|
||
| func (c *environmentCollector) environmentItemsQFX5220(client collector.Client, ch chan<- prometheus.Metric, labelValues []string) error { | ||
| x := environmentResultQFX5220{} |
There was a problem hiding this comment.
Please come up with a better variable name.
There was a problem hiding this comment.
Added the work Model to the variable name.
Original struct for the feature is called "multiEngineResult" so I am trying to follow this pattern
| func (c *environmentCollector) environmentPEMItemsQFX5220(client collector.Client, ch chan<- prometheus.Metric, labelValues []string) error { | ||
| x := environmentPEMResultQFX5220{} | ||
|
|
||
| stateValues := map[string]int{ |
| if err != nil { | ||
| return errors.Wrap(err, "failed to run command 'show version'") | ||
| } | ||
| // QFX5220 and EX4300 have a slightly different xml for environment information, so we need to check the product model before collecting environment metrics |
There was a problem hiding this comment.
I'm really wondering if this is not an QFX vs. EX general thing. Unfortunately we don't have access to other EX and QFX models. Well, at least we have QFX5110! Please double check!
There was a problem hiding this comment.
Looks like QFX5220 is different from QFX5110 and each of the is different from MX304
2 participants
No description provided.