Neovim LSP integration: Detach buffers only when attached#303
Merged
Davidyz merged 1 commit intoDavidyz:mainfrom Dec 26, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 25 25
Lines 1845 1845
=======================================
Hits 1840 1840
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for the contribution, and sorry for taking so long to process this. I was sick and couldn't take care of my Github. |
Contributor
Author
|
no worries - thanks for the hard work, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching to files that are not yet buffered I get the following error:
This appears to be as a result of a race condition when detaching buffers - something in my config is potentially detaching buffers and then vectorcode attempts to do the same after they are already detached.
I tried to create a minimal neovim repro, but with the extent of my config it'd be a nightmare to minimise, so I've provided a screencast instead:
Recording.at.2025-12-16.22.53.40.Cropped.in.2025-12-16.22.54.37._compressed.webm
Reproduction Steps
Expect: no error
Actual: error raised
Neovim Vectorcode Config
Solution
Before calling
vim.lsp.buf_detach_client, check that the buffer is attached usingvim.lsp.buf_is_attached