Skip to content

fix(core): fix width and height of map overlay#587

Open
dopenguin wants to merge 7 commits intonextfrom
fix/map-overlay
Open

fix(core): fix width and height of map overlay#587
dopenguin wants to merge 7 commits intonextfrom
fix/map-overlay

Conversation

@dopenguin
Copy link
Copy Markdown
Member

Summary

Update the width and the height of the map overlay. This was broken after #545.
Note that the overlay now is placed below the interface elements. I think this is quite nice. If you disagree, I'll change it back to the previous implementation.

Instructions for local reproduction and review

npm run snowbox and try scrolling via mousewheel.

@dopenguin dopenguin added this to the POLAR@3 milestone Mar 9, 2026
@dopenguin dopenguin self-assigned this Mar 9, 2026
@dopenguin dopenguin added the bug Something isn't working label Mar 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

PR Preview Action v1.8.0

QR code for preview link

🚀 View preview at
https://Dataport.github.io/polar/pr-preview/pr-587/

Built to branch gh-pages at 2026-04-22 14:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dopenguin dopenguin force-pushed the fix/map-overlay branch 2 times, most recently from f34ac73 to e334405 Compare March 17, 2026 16:12
Copy link
Copy Markdown
Member

@warm-coolguy warm-coolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 @dopenguin

Due to "Press Ctrl + Scroll to zoo", I prefer the prior solution of overlapping it all.

Image displaying that the current client cuts off the scroll instructions if UI elements are above it, rendering it ineffective

@dopenguin dopenguin force-pushed the fix/map-overlay branch 2 times, most recently from 8ae6b69 to df6ea26 Compare April 10, 2026 09:25
@dopenguin dopenguin force-pushed the fix/map-overlay branch 4 times, most recently from 8207cc8 to c44797b Compare April 20, 2026 17:45
@dopenguin
Copy link
Copy Markdown
Member Author

🏓 @dopenguin

Due to "Press Ctrl + Scroll to zoo", I prefer the prior solution of overlapping it all.
Image displaying that the current client cuts off the scroll instructions if UI elements are above it, rendering it ineffective

Took some more effort, but works now 488c3cc

🏓 @warm-coolguy @oeninghe-dataport

Copy link
Copy Markdown
Member

@warm-coolguy warm-coolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 @dopenguin While code regarding the one finger pan is present, it does work on the snowbox example in neither Android Chrome nor Safari Firefox. Please double-check.

It also occurred to me that NVDA does not read the hint. I figure that it should, in an utmost polite fashion. Do you agree? If so, I'll make it a separate issue.

@dopenguin
Copy link
Copy Markdown
Member Author

dopenguin commented Apr 21, 2026

🏓 @dopenguin While code regarding the one finger pan is present, it does work on the snowbox example in neither Android Chrome nor Safari Firefox. Please double-check.

It also occurred to me that NVDA does not read the hint. I figure that it should, in an utmost polite fashion. Do you agree? If so, I'll make it a separate issue.

Good catch, works now df6130c!

Screenreaders reading the hint seems like a good idea, please add an issue!

🏓 @warm-coolguy

Copy link
Copy Markdown
Member

@warm-coolguy warm-coolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 @dopenguin

On Safari mobile, in FullScreen mode, the hint is shown, albeit the map is panning. Please also check internal channel notes on Android behaviour, where we asked the team to check it on their devices.

Edit: According to tester feedback, Firefox seems to only sometimes display the hint.

Edit: According to tester feedback, with two fingers, both the map pan and the page scroll.

@dopenguin
Copy link
Copy Markdown
Member Author

🏓 @dopenguin

On Safari mobile, in FullScreen mode, the hint is shown, albeit the map is panning. Please also check internal channel notes on Android behaviour, where we asked the team to check it on their devices.

Edit: According to tester feedback, Firefox seems to only sometimes display the hint.

Edit: According to tester feedback, with two fingers, both the map pan and the page scroll.

The overlay should now be hidden when switching to fullscreen 9caea80.

I was not able to reproduce the behaviour of Firefox sometimes displaying the hint when it is not supposed to nor that the page scroll when panning with two fingers. Both was tested on an iPhone 15 Pro with iOS 26.4.1 and the latest versions of Firefox, Chrome and Safari.

🏓 @warm-coolguy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants