fix(core): fix width and height of map overlay#587
Conversation
|
f34ac73 to
e334405
Compare
warm-coolguy
left a comment
There was a problem hiding this comment.
ee2b68f to
9e1eb6b
Compare
8ae6b69 to
df6ea26
Compare
8207cc8 to
c44797b
Compare
Took some more effort, but works now 488c3cc |
There was a problem hiding this comment.
🏓 @dopenguin While code regarding the one finger pan is present, it does work on the snowbox example in neither Android Chrome nor Safari Firefox. Please double-check.
It also occurred to me that NVDA does not read the hint. I figure that it should, in an utmost polite fashion. Do you agree? If so, I'll make it a separate issue.
488c3cc to
8ff86f7
Compare
Good catch, works now df6130c! Screenreaders reading the hint seems like a good idea, please add an issue! |
There was a problem hiding this comment.
On Safari mobile, in FullScreen mode, the hint is shown, albeit the map is panning. Please also check internal channel notes on Android behaviour, where we asked the team to check it on their devices.
Edit: According to tester feedback, Firefox seems to only sometimes display the hint.
Edit: According to tester feedback, with two fingers, both the map pan and the page scroll.
…placed over all elements
…Pan so it is correctly blocked
5c05b6d to
bc777af
Compare
The overlay should now be hidden when switching to fullscreen 9caea80. I was not able to reproduce the behaviour of Firefox sometimes displaying the hint when it is not supposed to nor that the page scroll when panning with two fingers. Both was tested on an iPhone 15 Pro with iOS 26.4.1 and the latest versions of Firefox, Chrome and Safari. |


Summary
Update the width and the height of the map overlay. This was broken after #545.
Note that the overlay now is placed below the interface elements. I think this is quite nice. If you disagree, I'll change it back to the previous implementation.
Instructions for local reproduction and review
npm run snowboxand try scrolling via mousewheel.