fix(reverseGeocoder): abort ongoing requests if a new reverse geocode request comes in#571
fix(reverseGeocoder): abort ongoing requests if a new reverse geocode request comes in#571
Conversation
|
0c02dad to
21d3d96
Compare
96d23eb to
a515693
Compare
a515693 to
19bbfc6
Compare
19bbfc6 to
1fd20eb
Compare
1fd20eb to
0305b6d
Compare
a6674df to
d375ad5
Compare
… request comes in
d375ad5 to
3d99281
Compare
warm-coolguy
left a comment
There was a problem hiding this comment.
🏓 @dopenguin @oeninghe-dataport I closed the prior thread; if that pattern is to be changed, it should happen globally as a separate effort as proposed, and should prior to change be discussed in our Weekly.
Skimming the code, I found various instances of signal.aborted checks that were, in other spots, used to prevent spamming the console. I propose this technique is used here, too, to avoid confusion regarding "unerroring errors" further down the line.
So you propose moving the |
Yes, please. |
Been there, done that b032ba5 |
Summary
As the title states, reverse geocoding is now being aborted once a new request comes in. If this were not to be added, I could e.g. drag the pin around a few times and the map would keep centering on ALL position.
Instructions for local reproduction and review
Drag the pin around a few times in
iceberg. It should now only center the map on the last position.