Conversation
58e73f6 to
f941649
Compare
bb7336c to
6a3129e
Compare
|
The usually helpful variables (map, stores, etc.) are auto-exported as global variables for use with the browser's devtools in snowbox.
acbf752 to
425cfdb
Compare
# Conflicts: # examples/snowbox/services.js
dopenguin
left a comment
There was a problem hiding this comment.
- Please add an example to
iceberg; this maybe should include an example with a layer where the feature list is not being used - There should be no horizontal scrollbar if no features are available

- Some things are missing / quite different with the featureList; some parts are connections with the markers feature. This includes:
- When hovering an element in the feature list, the feature is highlighted in the map with the hover style
- When hovering an element in the map, the feature is highlighted in the feature list (previously green); when hovering a clustered feature, all features that are part of the cluster are highlighted
- If I select a feature in the map, it is selected in the feature list
- If I select a feature in the feature list, the corresponding marker gets the selected style; currently, a yellow dot is being displayed
- If I select a feature in the feature list, the map should be centered on that feature
- If a feature is not selectable because of the configured
isSelectablefunction, it is not being shown in the feature list
The list may not be complete, so please take a look at Meldemichel regarding the various things mentioned above.
I'll be taking a look at the components and stores once you've tackled these things.
| const features: Feature[] = [] | ||
| let feature: Feature | undefined | ||
|
|
||
| /* TODO: Format supposedly looks like this – is this a standard or arbitrary? |
There was a problem hiding this comment.
Are we able to answer this? Seems like a good point to maybe get rid of this comment
There was a problem hiding this comment.
Reading the current WMS spec, I could not find this format. However, this format may be specified in another way; or may at least be default for some implementations.
There was a problem hiding this comment.
Unfortunate! Please update the comment with your acquired knowledge.
| function getLayer(layerId: string) { | ||
| return map.value.getAllLayers().find((layer) => layer.get('id') === layerId) | ||
| } | ||
|
|
There was a problem hiding this comment.
There are 4 instances where we currently use coreStore.map.getLayers().getArray().find(...) where this action could also be used.
There was a problem hiding this comment.
Those 4 places are utils, and utils should not use stores (this would make unit tests harder, although we don't write them at the moment).
I also know that this rule is already violated in some utils, but I don't want to introduce more.
There was a problem hiding this comment.
Then that rather sounds like this action should become a utility function so it can be used across the project.
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
|
@oeninghe-dataport pls @ me once you've tackled all the things! |
For the hovering problems, this should be fixed with 9f25413. |
|
|
|
Feature list is not used, and you can choose between directSelect, directSelect + multiSelect, and coordinateSource from pins plugin. |
|
I think I've addressed all the points now. |

Summary
Migrate the GFI plugin.
Instructions for local reproduction and review
Additional hints
requestGfi*were migrated as-is and do not need to be reviewed therefore.Relevant tickets, issues, et cetera
Closes #368