perf(evm): cache internal call modules#529
Open
ZR74 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Introduces a transaction-local cache in ZenMockedEVMHost to reuse loaded EVMModule objects across repeated EVM CALLs, reducing module load/analyze/JIT overhead during replay/state tests.
Changes:
- Add an internal-call module cache keyed by code identity (address/hash/fingerprint/revision/memory specialization).
- Route internal CALL module loading through the cache and add cache management helpers.
- Add a unit test and a changelog-style doc describing the new caching behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tests/evm_test_host.hpp | Implements the internal CALL EVMModule cache and integrates it into CALL handling. |
| src/tests/evm_interp_tests.cpp | Adds a test asserting cache reuse vs. reload when bytecode changes. |
| docs/changes/2026-06-05-evm-host-call-module-cache/README.md | Documents motivation/impact and clarifies scope (CALL-only). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
176
to
180
| Result.ErrorMessage = "Runtime is not attached to ZenMockedEVMHost"; | ||
| return Result; | ||
| } | ||
| clearInternalCallModuleCache(); | ||
| const evmc_revision ActiveRevision = Config.Revision; |
Comment on lines
+69
to
+82
| size_t operator()(const InternalCallModuleCacheKey &Key) const noexcept { | ||
| size_t H = std::hash<evmc::address>{}(Key.CodeAddress); | ||
| H ^= std::hash<evmc::bytes32>{}(Key.AccountCodeHash) + | ||
| 0x9e3779b97f4a7c15ULL + (H << 6) + (H >> 2); | ||
| H ^= std::hash<uint64_t>{}(Key.CodeFingerprint) + 0x9e3779b97f4a7c15ULL + | ||
| (H << 6) + (H >> 2); | ||
| H ^= std::hash<size_t>{}(Key.CodeSize) + 0x9e3779b97f4a7c15ULL + | ||
| (H << 6) + (H >> 2); | ||
| H ^= std::hash<int>{}(static_cast<int>(Key.Revision)) + | ||
| 0x9e3779b97f4a7c15ULL + (H << 6) + (H >> 2); | ||
| H ^= std::hash<uint8_t>{}(Key.MemoryKey.SkipLeadingZeroLimbStores) + | ||
| 0x9e3779b97f4a7c15ULL + (H << 6) + (H >> 2); | ||
| return H; | ||
| } |
Comment on lines
+926
to
+933
| static uint64_t computeCodeFingerprint(const uint8_t *Data, size_t Size) { | ||
| uint64_t Hash = 1469598103934665603ULL; | ||
| for (size_t I = 0; I < Size; ++I) { | ||
| Hash ^= static_cast<uint64_t>(Data[I]); | ||
| Hash *= 1099511628211ULL; | ||
| } | ||
| return Hash; | ||
| } |
Comment on lines
+414
to
+462
| TEST(ZenMockedEVMHostModuleCacheTest, ReusesInternalCallModuleByCodeIdentity) { | ||
| RuntimeConfig Config; | ||
| #ifdef ZEN_ENABLE_MULTIPASS_JIT | ||
| Config.Mode = common::RunMode::MultipassMode; | ||
| #else | ||
| Config.Mode = common::RunMode::InterpMode; | ||
| #endif | ||
|
|
||
| auto MockedHost = std::make_unique<zen::evm::ZenMockedEVMHost>(); | ||
| auto RT = Runtime::newEVMRuntime(Config, MockedHost.get()); | ||
| ASSERT_TRUE(RT != nullptr) << "Failed to create runtime"; | ||
| MockedHost->setRuntime(RT.get()); | ||
|
|
||
| const evmc::address SenderAddr = evmc::literals::operator""_address( | ||
| "a94f5374fce5edbc8e2a8697c15331677e6ebf0b"); | ||
| const evmc::address ContractAddr = evmc::literals::operator""_address( | ||
| "00000000000000000000000000000000000000c1"); | ||
|
|
||
| evmc::MockedAccount SenderAccount; | ||
| SenderAccount.set_balance(1000); | ||
| MockedHost->accounts[SenderAddr] = SenderAccount; | ||
|
|
||
| evmc::MockedAccount ContractAccount; | ||
| ContractAccount.code = {0x60, 0x00, 0x50, 0x00}; // PUSH1 0; POP; STOP | ||
| ContractAccount.codehash.bytes[31] = 0xaa; | ||
| MockedHost->accounts[ContractAddr] = ContractAccount; | ||
|
|
||
| evmc_message Msg{}; | ||
| Msg.kind = EVMC_CALL; | ||
| Msg.gas = 100000; | ||
| Msg.recipient = ContractAddr; | ||
| Msg.sender = SenderAddr; | ||
| Msg.code_address = ContractAddr; | ||
|
|
||
| evmc::Result First = MockedHost->call(Msg); | ||
| ASSERT_EQ(First.status_code, EVMC_SUCCESS); | ||
| EXPECT_EQ(MockedHost->getInternalCallModuleCacheSize(), 1U); | ||
|
|
||
| evmc::Result Second = MockedHost->call(Msg); | ||
| ASSERT_EQ(Second.status_code, EVMC_SUCCESS); | ||
| EXPECT_EQ(MockedHost->getInternalCallModuleCacheSize(), 1U); | ||
|
|
||
| // Same address and codehash but different bytecode must not reuse the cached | ||
| // module. This protects replay tests from stale code when state changes. | ||
| MockedHost->accounts[ContractAddr].code = {0x60, 0x01, 0x50, 0x00}; | ||
| evmc::Result Third = MockedHost->call(Msg); | ||
| ASSERT_EQ(Third.status_code, EVMC_SUCCESS); | ||
| EXPECT_EQ(MockedHost->getInternalCallModuleCacheSize(), 2U); | ||
| } |
⚡ Performance Regression Check Results✅ Performance Check Passed (interpreter)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions ✅ Performance Check Passed (multipass)Performance Benchmark Results (threshold: 25%)
Summary: 194 benchmarks, 0 regressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note