Conversation
si-zero
approved these changes
May 10, 2026
Contributor
si-zero
left a comment
There was a problem hiding this comment.
기존에 작성하셨던 코드들을 prisma 로 바꾸는 작업이 쉽지 않으셨을텐데 정말 고생하셨습니다.
prisma 를 사용하면 복잡한 쿼리문을 작성할 필요 없이 저희에게 굉장히 익숙한 메소드 형식으로 쿼리문을 작성할 수 있습니다. 피드백 드린 내용도 확인해보시고 바꿔보시면 정말 좋을 것 같습니다.
Contributor
There was a problem hiding this comment.
각 도메인별 에러코드를 설정해둔건 정말 좋은 방향성입니다.
나중에 도메인이 많아지고 에러코드 종류가 많아지면 도메인별로 에러코드를 분리하는 것도 좋은 방향입니다.
Contributor
There was a problem hiding this comment.
현재 유효성 검증 로직이 분리되어 있지 않습니다.
API 수가 많지 않아 중복되는 검증 로직이 없어서 언년님께서 분리해두지 않은 것으로 보입니다.
나중에는 분리하는 방향도 엄청 좋아보이네요!
| model MemberMission { | ||
| memberId BigInt @map("member_id") | ||
| missionId BigInt @map("mission_id") | ||
| status String? @default("CHALLENGING") @db.VarChar(20) |
Contributor
There was a problem hiding this comment.
미션 상태와 같은 컬럼은 들어갈 데이터가 정해져 있습니다.
해당 부분은 enum 으로 분리해보는 방향도 엄청 좋을 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
구현 API
GET /api/v1/members/:memberId/reviews- 내가 작성한 리뷰 목록GET /api/v1/stores/:storeId/missions- 특정 가게의 미션 목록GET /api/v1/members/:memberId/missions- 내가 진행 중인 미션 목록PATCH /api/v1/members/:memberId/missions/:missionId/complete- 미션 완료 처리Test plan
관련 이슈
closes #29