make-legendary: Add 'fortress' option to make all fortress citizens l…#1421
Closed
younes-io wants to merge 1 commit intoDFHack:masterfrom
Closed
make-legendary: Add 'fortress' option to make all fortress citizens l…#1421younes-io wants to merge 1 commit intoDFHack:masterfrom
younes-io wants to merge 1 commit intoDFHack:masterfrom
Conversation
myk002
reviewed
Mar 22, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
Looks good! Please also add a line to the Misc Improvements section of the "Future" version in the changelog.txt file. Also, please add documentation for the new option in docs/make-legendary.rst.
Member
|
also, it looks like the linter found trailing whitespace in the file. Please fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new
fortressoption tomake-legendary.luathat makes all fortress citizens legendary in all skills at once. Usesdfhack.units.getCitizens()for reliable citizen detection.Usage:
make-legendary fortress