Pin guard: cover the 2 vendored id-label test files (culturebotai-claw#6)#64
Merged
Conversation
Closes the CultureMech side of culturebotai-claw#6 (NEXT_TASKS item 3). The verify-validator-pin guard pinned only validate_id_label_correspondence.py, so the two byte-identical-across-Mechs test files (test_id_label_empty_adapter.py, test_id_label_unknown_prefix.py) could silently drift. Extend the sha256 manifest + refresh-validator-pin to cover all three via a VENDORED_IDLABEL_FILES list. conf/id_label_targets.yaml stays UNpinned — it's intentionally per-repo. Verified: guard passes on the pinned set; editing a vendored test now fails it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the CultureMech side of culturebotai-claw#6 (NEXT_TASKS item 3).
verify-validator-pinpinned onlyvalidate_id_label_correspondence.py, leaving the two byte-identical-across-Mechs vendored test files unguarded — a one-copy edit would pass CI everywhere while breaking the invariant.Fix (issue's Option 1)
Extend the sha256 manifest +
refresh-validator-pinto cover all three vendored files via aVENDORED_IDLABEL_FILESlist:scripts/validate_id_label_correspondence.pytests/test_id_label_empty_adapter.pytests/test_id_label_unknown_prefix.pyconf/id_label_targets.yamlstays unpinned — it's intentionally per-repo (different adapters/targets/exceptions), per the issue.Verified
verify-validator-pin(exit 1).🤖 Generated with Claude Code