Normalize malformed hydrate ingredient names to canonical ' x N H2O'#60
Merged
Conversation
Fix parse-artifact hydrate preferred_terms (84 occurrences, 24 files) by mapping each to the corpus's dominant clean sibling sharing its separator-stripped key: - concatenated, no separator: CaCl22H2O -> CaCl2 x 2 H2O, CoSO47H2O, MnCl24H2O - 'x' without spaces: MgSO4x7H2O -> MgSO4 x 7 H2O, CaCl2x2H2O - rare dot-operator unicode: FeSO4⋅7H2O / MgSO4∙7H2O -> ' x ' form Established '·' (U+00B7) / '・' (U+30FB) middot notation is left untouched (it is a widely-used style, not a parse artifact). Forms with no matching-hydrate clean sibling (e.g. CuCl2⋅4H2O, Na2Sx6H2O) are left as-is rather than mapped to a different hydrate. Grounding (term.id) is unaffected; linkml-validate clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes parse-artifact hydrate
preferred_terms (84 occurrences across 24 files) by mapping each to the corpus's dominant clean sibling (x N H2O) sharing its separator-stripped key.Targeted (genuinely malformed)
CaCl22H2O→CaCl2 x 2 H2O,CoSO47H2O,MnCl24H2O,Na2MoO42H2O,NiCl26H2O,FeCl36H2O.xwithout spaces:MgSO4x7H2O→MgSO4 x 7 H2O,CaCl2x2H2O,CaCl2 x2H2O.⋅/ U+2219∙):FeSO4⋅7H2O/MgSO4∙7H2O→xform.Deliberately left untouched
·(U+00B7) and・(U+30FB) middot notation — a widely-used style (hundreds of occurrences), not a parse artifact. Unifying all separators would be a ~7k-row cosmetic churn with no grounding benefit.CuCl2⋅4H2O,Na2Sx6H2O,Ni2SO4 ⋅ 6H2O) — left as-is rather than mapped to a different hydrate.Grounding (
term.id) is unaffected; mapping is corpus-driven (only maps to an existing canonical of the same hydrate).linkml-validate: 24/24 clean.🤖 Generated with Claude Code