fix: fix iphone audio playback by adding loadedmetadata listener#338
Open
Nimit012 wants to merge 1 commit intoCreateJS:masterfrom
Open
fix: fix iphone audio playback by adding loadedmetadata listener#338Nimit012 wants to merge 1 commit intoCreateJS:masterfrom
Nimit012 wants to merge 1 commit intoCreateJS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Audio was intermittently not playing on iPhone when using HTMLAudioPlugin.
Root Cause
The
canplaythroughevent wasn't firing reliably on iPhone, which prevented the_loadedHandlerfrom being invoked. This caused audio to fail loading silently without any error indication.Solution
Added
loadedmetadataevent listener as a fallback to ensure the load handler is called on iPhone wherecanplaythroughis unreliable.