Conversation
|
hey skroink, you don't actually edit the files in the lib directory directly, and actually you shouldn't submit any of the changes to files in the lib folder. Instead you change the source file (src/createjs/utils/Ticker.js in this case) and submit that. You can use grunt as explained in the build folder's readme ( here ) to concatenate the file for local testing. If you're just adding |
|
Thank you for your response, I'll be suggesting a commit using you guidelines. |
|
This is definitey a request I would like to merge, however it looks like you just did a find/replace for performance, so there are a ton of doc changes that are now incorrect:
I had a fix ready to go for the reported issue, which is a little more succinct. I was going to commit it, but I think the updates to other window-level properties (document) are helpful too. If you can clean up the incorrect changes, and use the snippet below, I can review and merge this one. var perf = window.performance,
now = perf && (perf.now || perf.mozNow || perf.msNow || perf.oNow || perf.webkitNow);
Ticker._getTime = function() {
return ((now&&now.call(perf))||(new Date().getTime())) - Ticker._startTime;
};Thanks! |
In response to this thread, I've added a new file
easel-nw.combined.jsthat supports node-webkit.