Skip to content

fix: unify workspace show divider widths #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
694410194 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

fix: unify workspace show divider widths #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/cortex-cli/src/workspace_cmd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ use clap::Parser;
use serde::{Deserialize, Serialize};
use std::path::PathBuf;

const WORKSPACE_SECTION_RULE_WIDTH: usize = 50;

/// Workspace CLI command.
#[derive(Debug, Parser)]
pub struct WorkspaceCli {
Expand Down Expand Up @@ -184,15 +186,15 @@ async fn run_show(args: WorkspaceShowArgs) -> Result<()> {
}

println!("Workspace Information");
println!("{}", "=".repeat(50));
println!("{}", "=".repeat(WORKSPACE_SECTION_RULE_WIDTH));
println!(" Root: {}", info.root.display());
if let Some(ref name) = info.project_name {
println!(" Project: {}", name);
}
println!();

println!("Configuration:");
println!("{}", "-".repeat(40));
println!("{}", "-".repeat(WORKSPACE_SECTION_RULE_WIDTH));
println!(
" .cortex/config.toml: {}",
if info.has_cortex_config {
Expand All @@ -217,7 +219,7 @@ async fn run_show(args: WorkspaceShowArgs) -> Result<()> {
if let Some(ref settings) = info.settings {
println!();
println!("Workspace Settings:");
println!("{}", "-".repeat(40));
println!("{}", "-".repeat(WORKSPACE_SECTION_RULE_WIDTH));
if let Some(ref model) = settings.model {
println!(" Model: {}", model);
}
Expand Down Expand Up @@ -628,6 +630,13 @@ mod tests {
assert!(args.json);
}

#[test]
fn test_workspace_show_rule_width_is_consistent() {
assert_eq!(WORKSPACE_SECTION_RULE_WIDTH, 50);
assert_eq!("=".repeat(WORKSPACE_SECTION_RULE_WIDTH).len(), 50);
assert_eq!("-".repeat(WORKSPACE_SECTION_RULE_WIDTH).len(), 50);
}

// ==========================================================================
// WorkspaceInitArgs tests
// ==========================================================================
Expand Down