Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 49 additions & 3 deletions src/cortex-cli/src/exec_cmd/runner.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//! Execution runner for exec mode.

use std::io::{self, BufRead, IsTerminal, Read, Write};
use std::path::PathBuf;
use std::path::{Path, PathBuf};
use std::time::{Duration, Instant};

use anyhow::{Context, Result, bail};
Expand Down Expand Up @@ -82,9 +82,15 @@ impl ExecCli {

// Read from file if specified
if let Some(ref file_path) = self.file {
let content = tokio::fs::read_to_string(file_path)
let resolved_file_path = resolve_prompt_file_path(file_path, self.cwd.as_deref());
let content = tokio::fs::read_to_string(&resolved_file_path)
.await
.with_context(|| format!("Failed to read prompt file: {}", file_path.display()))?;
.with_context(|| {
format!(
"Failed to read prompt file: {}",
resolved_file_path.display()
)
})?;
prompt.push_str(&content);
}

Expand Down Expand Up @@ -852,3 +858,43 @@ impl ExecCli {
Ok(())
}
}

fn resolve_prompt_file_path(file_path: &Path, cwd: Option<&Path>) -> PathBuf {
if file_path.is_absolute() {
file_path.to_path_buf()
} else if let Some(cwd) = cwd {
cwd.join(file_path)
} else {
file_path.to_path_buf()
}
}

#[cfg(test)]
mod tests {
use super::resolve_prompt_file_path;
use std::path::{Path, PathBuf};

#[test]
fn resolve_prompt_file_path_uses_cwd_for_relative_paths() {
let cwd = PathBuf::from("workspace").join("nested");
let resolved = resolve_prompt_file_path(Path::new("script.sh"), Some(&cwd));

assert_eq!(resolved, cwd.join("script.sh"));
}

#[test]
fn resolve_prompt_file_path_keeps_absolute_paths() {
let absolute_file_path = std::env::temp_dir().join("script.sh");
let resolved =
resolve_prompt_file_path(&absolute_file_path, Some(Path::new("workspace/nested")));

assert_eq!(resolved, absolute_file_path);
}

#[test]
fn resolve_prompt_file_path_keeps_relative_path_without_cwd() {
let resolved = resolve_prompt_file_path(Path::new("script.sh"), None);

assert_eq!(resolved, Path::new("script.sh"));
}
}
9 changes: 9 additions & 0 deletions src/cortex-cli/src/plugin_cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,13 @@ async fn run_remove(args: PluginRemoveArgs) -> Result<()> {
let plugins_dir = get_plugins_dir();
let plugin_path = plugins_dir.join(&args.name);

tracing::debug!(
plugin = %args.name,
plugins_dir = %plugins_dir.display(),
plugin_path = %plugin_path.display(),
"Preparing to remove plugin"
);

if !plugin_path.exists() {
bail!("Plugin '{}' is not installed.", args.name);
}
Expand All @@ -1159,12 +1166,14 @@ async fn run_remove(args: PluginRemoveArgs) -> Result<()> {
let mut input = String::new();
std::io::stdin().read_line(&mut input)?;
if !input.trim().eq_ignore_ascii_case("y") {
tracing::debug!(plugin = %args.name, "Plugin removal aborted by user");
println!("Aborted.");
return Ok(());
}
}

std::fs::remove_dir_all(&plugin_path)?;
tracing::debug!(plugin = %args.name, "Plugin directory removed successfully");
println!("Plugin '{}' removed successfully.", args.name);
Ok(())
}
Expand Down