Fix ArtifactPathInfo to reject non-standard paths#112
Merged
ruhan1 merged 1 commit intoCommonjava:masterfrom Dec 12, 2025
Merged
Fix ArtifactPathInfo to reject non-standard paths#112ruhan1 merged 1 commit intoCommonjava:masterfrom
ruhan1 merged 1 commit intoCommonjava:masterfrom
Conversation
pkocandr
approved these changes
Dec 11, 2025
Contributor
pkocandr
left a comment
There was a problem hiding this comment.
I would probably remove the redhat suffix from the example path used in the test, but otherwise it looks to fix the issue we currently have.
Add validation to ensure filenames follow Maven naming convention (artifactId-version-...) and reject paths where the regex matches but produces incorrect parsing results. This prevents mis-parsing of non-standard paths like RPM artifacts that don't conform to Maven layout. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
373d276 to
d4331a6
Compare
Contributor
Author
Agree and removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation to ensure filenames follow Maven naming convention (artifactId-version-...) and reject paths where the regex matches but produces incorrect parsing results. This prevents mis-parsing of non-standard paths like RPM artifacts that don't conform to Maven layout.
🤖 Generated with Claude Code