fix: move revenueholdings-license to optional [license] extra#1
Open
Coding-Dev-Tools wants to merge 1 commit into
Open
fix: move revenueholdings-license to optional [license] extra#1Coding-Dev-Tools wants to merge 1 commit into
Coding-Dev-Tools wants to merge 1 commit into
Conversation
…aceful import fallback - Remove revenueholdings-license>=0.1.0 from required dependencies - Add license optional-dependencies group with revenueholdings-license - Make require_license() import conditional: try/except ImportError - On ImportError, define no-op require_license() and print warning - Fixes CI breakage caused by revenueholdings-license not on PyPI (COM-79, COM-82, COM-83)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pip installfails on CI becauserevenueholdings-license>=0.1.0is listed as a required dependency but the package was never published to PyPI (blocked by hCaptcha — see COM-79, COM-82, COM-83).Fix
revenueholdings-license>=0.1.0fromdependenciesto[project.optional-dependencies] licenserequire_license()import conditional — onImportError, defines a no-op placeholder and emits a warningImpact
pip installwill succeed without the license packagepip install json2sql[license]will still get license enforcement when the package becomes available on PyPIrevenueholdings-licenseIS installedRefs: COM-137, COM-79, COM-82, COM-83