[Hermes] Remove npm-publish.yml and harden CI workflow security#10
Closed
Coding-Dev-Tools wants to merge 1 commit into
Closed
[Hermes] Remove npm-publish.yml and harden CI workflow security#10Coding-Dev-Tools wants to merge 1 commit into
Coding-Dev-Tools wants to merge 1 commit into
Conversation
- Remove npm-publish.yml (wrong-language workflow for Python repo) - Add persist-credentials: false to all checkout steps (ci, publish, pages) - Add top-level permissions: contents: read to ci.yml - Update pages.yml checkout from v4 to v6
Owner
Author
|
Closing: This repo has a legitimate npm wrapper (package.json + cli.js). The npm-publish.yml workflow should be kept. See configdrift#9 for rationale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove wrong-language npm-publish.yml and harden all CI workflow security settings.
Why this change
What changed
.github/workflows/npm-publish.yml— wrong-language workflowpersist-credentials: falseto checkout steps in: ci.yml, publish.yml, pages.ymlpermissions: contents: readto ci.yml (least-privilege)Validation performed
ruff check src/→ All checks passedpytest tests/ -q→ 49 passedRisks/rollback
Follow-ups