Skip to content

[Hermes] Remove npm-publish.yml (wrong-language CI workflow)#8

Merged
Coding-Dev-Tools merged 1 commit into
mainfrom
hermes/configdrift/remove-npm-publish-workflow
May 18, 2026
Merged

[Hermes] Remove npm-publish.yml (wrong-language CI workflow)#8
Coding-Dev-Tools merged 1 commit into
mainfrom
hermes/configdrift/remove-npm-publish-workflow

Conversation

@Coding-Dev-Tools
Copy link
Copy Markdown
Owner

Summary

Removes .github/workflows/npm-publish.yml — a Node.js/npm publishing workflow that does not belong in this Python repository.

Why this change

  • Wrong-language CI workflow: This is a Python project published to PyPI, not an npm package. The npm-publish.yml workflow would fail on release since there is no package.json or Node.js project.
  • Template artifact: This workflow was likely carried over from a repo template and is redundant — the repo already has publish.yml for PyPI releases.
  • Prevents confusion: Having npm-publish.yml could mislead contributors into thinking this is a JavaScript project, or cause unexpected CI failures if someone sets up NPM_TOKEN.

What changed

  • Deleted .github/workflows/npm-publish.yml

Validation performed

  • ruff check . — All checks passed
  • python -m pytest tests/ -q — 35 passed
  • Verified publish.yml (PyPI) still exists for proper Python releases

Risks / rollback

  • Zero risk — removing a workflow that never works in this repo
  • Rollback: re-add the file from git history

Follow-ups

  • 4 other Python repos in the portfolio have the same npm-publish.yml artifact: deadcode, deploydiff, apighost, schemaforge — same fix should be applied

This Python repo uses publish.yml for PyPI releases.
npm-publish.yml is a template artifact that would fail on release
since there is no package.json or Node.js project.
@Coding-Dev-Tools Coding-Dev-Tools merged commit 888efcf into main May 18, 2026
3 checks passed
Coding-Dev-Tools added a commit that referenced this pull request May 18, 2026
The npm-publish.yml was incorrectly removed in PR #8 based on the assumption
that Python repos should not have npm-publish workflows. However, this repo
has a legitimate npm wrapper (package.json + cli.js) that allows users to
install via 'npm install -g configdrift'. The npm-publish workflow is needed
to publish this wrapper to the npm registry.

Reverts the npm-publish.yml removal from commit 888efcf.

Co-authored-by: DevForge Engineer <engineer@devforge.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant