noteAngle rewrite (+ -scrollSpeed fix)#857
Open
betpowo wants to merge 3 commits intoCodenameCrew:mainfrom
Open
noteAngle rewrite (+ -scrollSpeed fix)#857betpowo wants to merge 3 commits intoCodenameCrew:mainfrom
betpowo wants to merge 3 commits intoCodenameCrew:mainfrom
Conversation
cool , sustains now dont look like ass when rotated and negative scroll speed doesnt mess tem up anymore although the consequence of this is that noteAngle will go the other way around if on downscroll but i cant rlly get myself to fix that ;-;
Member
|
Like your mod name here? |
Contributor
Author
yes...like the mod name of here........but hardcoded instead and also doesnt turn off strumRelativePos so it could be better..... |
Member
|
mhhhh maybe we should try to fix downscroll before merging |
Contributor
|
woah |
betpowo
changed the title
Member
|
oh it got conflicted, ill fix it |
Contributor
|
It still conflicting, bro. |
Member
|
it wasnt conflicted im kms |
Member
|
Please someone resolve the conflicts and check if this is good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cool , sustains now dont look like ass when rotated and negative scroll speed doesnt mess them up anymore
although the consequence of this is that noteAngle will go the other way around if on downscroll but i cant rlly get myself to fix that ;-; And frameOffset is now unaffected by noteAngle if strumRelativePos is true which i think is cool ok . also fixes them popping on screen suddenly but at the cost of not using frameoffset which idk if it breaks things . actually
this will break mods that for some reason use these variables for very specific purposes