[FEATURE] Improve support for pixel ratio > 1#80
Open
koehnlein wants to merge 1 commit intoCodeception:masterfrom
Open
[FEATURE] Improve support for pixel ratio > 1#80koehnlein wants to merge 1 commit intoCodeception:masterfrom
koehnlein wants to merge 1 commit intoCodeception:masterfrom
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of the PR improves generating screenshots for all devices with pixel ratio > 1. The lines koehnlein@c15c294#diff-23be3accec9cccd7a4b66e668a0a62586dec7eb7f4d2fc2b47419a46c6f2feb1R508-R513 include the pixel ratio when calculating the image cropping. Before this change, e.g. with "pixel ratio = 2", only the upper left quarter of the requested area was kept after cropping.
The second part is a new configuration option, described in readme.md: