Skip to content

London | 26-ITP-January | Carlos Abreu | Sprint 2 | Form Controls#1155

Open
carlosyabreu wants to merge 4 commits intoCodeYourFuture:mainfrom
carlosyabreu:feature/form-controls
Open

London | 26-ITP-January | Carlos Abreu | Sprint 2 | Form Controls#1155
carlosyabreu wants to merge 4 commits intoCodeYourFuture:mainfrom
carlosyabreu:feature/form-controls

Conversation

@carlosyabreu
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Form controls project to be merge into upstream main branch

@netlify
Copy link

netlify bot commented Feb 6, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 8c501e5
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/69868036ad484c00082304ab
😎 Deploy Preview https://deploy-preview-1155--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 6, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@carlosyabreu carlosyabreu changed the title London | 26-ITP-January | Carlos Abreu | Sprint 1 | Form Controls London | 26-ITP-January | Carlos Abreu | Sprint 2 | Form Controls Feb 7, 2026
@carlosyabreu carlosyabreu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for you.

name="customer-name"
required
minlength="2"
placeholder="Enter first and last name">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of another way to verify if the customer name is a valid name

id="customer-email"
name="customer-email"
required
placeholder="example@domain.com">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also think of another way to verify if the customer email is a valid email?

@A-O-Emmanuel A-O-Emmanuel added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants