GLASGOW | ITP JANUARY 2026 | PRAKASH DCOSTA | Sprint 2 | Form Control#1144
Open
dcostaprakash wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
GLASGOW | ITP JANUARY 2026 | PRAKASH DCOSTA | Sprint 2 | Form Control#1144dcostaprakash wants to merge 3 commits intoCodeYourFuture:mainfrom
dcostaprakash wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dcostaprakash
added
the
Needs Review
WeiTsungCheng
added
Review in progress
| <div> | ||
| <label for="email">Email</label> | ||
| <br> | ||
| <Input type="email" name="email" id="email" required> |
| <label for="Tshirtcolour">Tshirt colour</label> | ||
| <br> | ||
| <select name="Tshirtcolour" id="Tshirtcolour" required> | ||
| <option value> Select a colour</option> |
There was a problem hiding this comment.
The first option should not be selected
WeiTsungCheng
left a comment
WeiTsungCheng
left a comment
There was a problem hiding this comment.
Good attempt, but many HTML rules need to be considered.
| <label for="Tshirtsize">Tshirt size</label> | ||
| <br> | ||
| <select name="Tshirtsize" id="Tshirtsize" required> | ||
| <option value> Select a size</option> |
There was a problem hiding this comment.
The first option should not be selected
| <br> | ||
| <select name="Tshirtsize" id="Tshirtsize" required> | ||
| <option value> Select a size</option> | ||
| <option value="XS">XS</option> |
There was a problem hiding this comment.
html format is wrong
correct format is:
| <footer> | ||
| <!-- change to your name--> | ||
| <h2>By HOMEWORK SOLUTION</h2> | ||
| <form action="results.html" method="GET"> |
There was a problem hiding this comment.
HTML does not allow a form to be wrapped inside another form
WeiTsungCheng
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Created a form as per the requirements and tested it