WestMidlands | 26-ITP-Jan | Adedolapo Bamiduro | Sprint 2 | Form Controls#1127
Open
codebydolz wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
WestMidlands | 26-ITP-Jan | Adedolapo Bamiduro | Sprint 2 | Form Controls#1127codebydolz wants to merge 1 commit intoCodeYourFuture:mainfrom
codebydolz wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
codebydolz
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
codebydolz
changed the title
This comment has been minimized.
This comment has been minimized.
Poonam-raj
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
codebydolz
added
the
Needs Review
cjyuan
reviewed
Feb 6, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are some warnings in your code. Can you address them?
-
Currently a user can submit the form without filling in all input.
-
Common practice is to keep the label of a radio button on the right (instead of at the bottom)
- Note: Embedded CSS is still CSS. Supposedly the requirement says "No CSS", but you can keep them.
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
| <main id="main-content"> | ||
| <form action="results.html" method="get"> |
Contributor
There was a problem hiding this comment.
For testing, we could set the action value to "#" so that the form data is sent to the URL of this page.
Comment on lines
+51
to
+58
| <select name="size" id="size"> | ||
| <option value="XS">Extra Small</option> | ||
| <option value="S">Small</option> | ||
| <option value="M">Medium</option> | ||
| <option value="L">Large</option> | ||
| <option value="XL">Extra Large</option> | ||
| <option value="XXL">Extra Extra Large</option> | ||
| </select> |
Contributor
There was a problem hiding this comment.
There is a way to configure a <select> element so that no option is selected by default, allowing the user to make an explicit choice.
Comment on lines
+64
to
+65
| <input type="radio" name="color" id="color-blue" value="Blue"> | ||
| <label for="color-blue">Blue</label> |
Contributor
There was a problem hiding this comment.
We won't need to use id and for if we encode this as:
<label>
<input type="radio" name="color" value="Blue">
Blue
</label>
Comment on lines
+77
to
+80
| <div class="form-row"> | ||
| <label for="password">Password</label> | ||
| <input type="password" name="password" id="password" required aria-required="true"> | ||
| </div> |
Contributor
There was a problem hiding this comment.
I am glad that you are trying different things, but I think it is weird to include a password input field in a T-shirt ordering form. :)
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
added the needed answers to form controls