Skip to content

Glasgow | January 2026 | PRAKASH DCOSTA | Sprint 1 | Wireframe#1124

Open
dcostaprakash wants to merge 4 commits intoCodeYourFuture:mainfrom
dcostaprakash:feature/wireframe
Open

Glasgow | January 2026 | PRAKASH DCOSTA | Sprint 1 | Wireframe#1124
dcostaprakash wants to merge 4 commits intoCodeYourFuture:mainfrom
dcostaprakash:feature/wireframe

Conversation

@dcostaprakash
Copy link

@dcostaprakash dcostaprakash commented Feb 3, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Have made the Wireframe Webpage as per the guidelines which have connectivity to other web pages.

Questions

No questions

@netlify
Copy link

netlify bot commented Feb 3, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c2bf253
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6987e84ac19ae10008b2e7ca
😎 Deploy Preview https://deploy-preview-1124--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
6 similar comments
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@dcostaprakash dcostaprakash added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 3, 2026
cjyuan
cjyuan reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objective of the exercise is to modify only index.html and style.css to make a page looks like the given wireframe.

The main purpose of implementing a wireframe is to translate structure and functionality, not final visual design. Visual design is usually handled by UI/graphic designers after the wireframe phase. You can even use the same image, placeholder.svg in all three articles.

Can you take a look at this General Feedback to see if there
is anything else you can do to make your PR more robust and ready?
Doing so can help speed up the review process.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 6, 2026
@dcostaprakash dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 7, 2026
cjyuan
cjyuan reviewed Feb 7, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you

    • Make the image span the full width of the articles
    • Center the "SHORT DESCRIPTION" beneath the title (instead of left-align it)

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 7, 2026
@dcostaprakash dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 8, 2026
cjyuan
cjyuan reviewed Feb 8, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML looks good.

CSS could use some improvement.

Wireframe/style.css Outdated
Comment on lines 91 to 95
.Wireframe {
float: left;
width: 50%;
padding: 15px;
}
Copy link
Contributor

@cjyuan cjyuan Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS Class names are case-sensitive. I think it is a better practice to consistently use lowercase letters for class name.

It seems .Wireframe is not being used in index.html.

Wireframe/style.css Outdated
Comment on lines 102 to 104
.article {
width: auto;
}
Copy link
Contributor

@cjyuan cjyuan Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easy to mix up .article and article in CSS. I think it is better to avoid class names like this.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 8, 2026
@dcostaprakash dcostaprakash added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcostaprakash @cjyuan