Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 1 | Feature Wireframe

[Alaterry8]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I added 3 new articles that contain titles, summaries, images and links. I styled the articles with CSS to change the background colour. I changed the footer colour.

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	283c375
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6986f54648177a00082e44cf
😎 Deploy Preview	https://deploy-preview-1100--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 94 (🔴 down 6 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

Code is free of syntax errors and well indented. Well done.

1

When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Center the PAGE TITLE and the SHORT DESCRIPTION beneath it
- Center the text on the footer
?

2

Can you improve the Lighthouse accessibility score to 100?

3

The footer content and the article content could overlap when the user scrolls the content. Can you address this issue (to improve user experience)?

[Alaterry8]

Hey @cjyuan I added the missing parts and fixed the contrast issue, thanks for the feedback!

[cjyuan]

You addressed all comments. Good job!

However, now one of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", is no longer satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

[Alaterry8]

Hey @cjyuan, I think it should be good now, thanks! :D

[cjyuan]

• The footer is covering the bottom border of articles 2 and 3. Can you leave more room between the footer and the last two articles?

• Please note that in CYF courses, when your changes is ready to be reviewed, you should also add the "Needs review" label to the PR.

[cjyuan]

Changes look good.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • You may find the suggestions in this PR Guide useful.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.