Nw6-Ayman-Matoo/HTML-CSS-Project week2#658
Open
Ayman-matoo wants to merge 2 commits intoCodeYourFuture:masterfrom
Open
Nw6-Ayman-Matoo/HTML-CSS-Project week2#658Ayman-matoo wants to merge 2 commits intoCodeYourFuture:masterfrom
Ayman-matoo wants to merge 2 commits intoCodeYourFuture:masterfrom
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hoduola5
requested changes
Nov 20, 2023
hoduola5
left a comment
hoduola5
left a comment
There was a problem hiding this comment.
Good job @Ayman-matoo!
However, check my comments in your PR and try to effect the changes.
Another important thing is to fill the PR template to reflect your name, challenges, and other questions there to help guide you properly.
Comment on lines
+58
to
+70
| <footer> | ||
|
|
||
| <p class ="test">Join Us</p> | ||
| <img class="icon" src="/img/twitter-icon.svg"> | ||
|
|
||
|
|
||
| <img class= "icon2" src="/img/instagram-icon.svg"> | ||
|
|
||
|
|
||
| <img src="/img/facebook-icon.svg"> | ||
| <p>Karma Mobile.int</p> | ||
|
|
||
| </footer> |
There was a problem hiding this comment.
The footer icons are in circular border and not as big as you have them in your PR, kindly work around it and do reach out if you are finding it difficult.
| <section class="image1"> | ||
| <h1>Inroducing karma</h1> | ||
| <p>Bring wifi with you everywhere, you go</p> | ||
| <button class="button">learn more</button> |
There was a problem hiding this comment.
You need to style this button to look like the one on the assignment, such as working on giving it some padding, and the letter case etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?