NW6 | Pedram Amani | HTML-CSS | Module Project | Week 1,2,4#640
Open
pedram-am wants to merge 12 commits intoCodeYourFuture:masterfrom
Open
NW6 | Pedram Amani | HTML-CSS | Module Project | Week 1,2,4#640pedram-am wants to merge 12 commits intoCodeYourFuture:masterfrom
pedram-am wants to merge 12 commits intoCodeYourFuture:masterfrom
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bunday
suggested changes
Oct 5, 2023
bunday
left a comment
bunday
left a comment
There was a problem hiding this comment.
Well done,
See my comment about the margin on the whole body. Also can you try to reduce the overall font a bit?
| */ | ||
|
|
||
| body { | ||
| margin: 40px; |
There was a problem hiding this comment.
Adding a margin on the entire body affects the image from filling the sides of the screen, can you remove this margin and apply it to appropriate elements
pedram-am
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
The text content part.
What did you find hard?
Adjusting layouts, design requirements and troubleshooting issues.
What do you still not understand?
Keeping images, texts and layouts clear and maintaining their quality when the screen size changes.
Any other notes?
No.