Skip to content

fix: skip warmup for embedded benchmarks#10

Open
not-matthias wants to merge 1 commit intomainfrom
cod-2548-investigate-warmup-included-in-flamegraphs-in-100ns
Open

fix: skip warmup for embedded benchmarks#10
not-matthias wants to merge 1 commit intomainfrom
cod-2548-investigate-warmup-included-in-flamegraphs-in-100ns

Conversation

@not-matthias
Copy link
Copy Markdown
Member

Replace the inline isWarmupFork() check inside runBenchmark's
measurement loop with an explicit isWarmup flag computed in doSingle
from !mode.doMeasurement() || isWarmupFork().

Groundwork for COD-2548 (warmup leaking into flamegraphs for <100ns
benchmarks): centralises the warmup-vs-measurement decision so the
outer startBenchmark/stopBenchmark scope can be tightened next.

Replace the inline isWarmupFork() check inside runBenchmark's
measurement loop with an explicit isWarmup flag computed in doSingle
from `!mode.doMeasurement() || isWarmupFork()`.

Groundwork for COD-2548 (warmup leaking into flamegraphs for <100ns
benchmarks): centralises the warmup-vs-measurement decision so the
outer startBenchmark/stopBenchmark scope can be tightened next.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 24, 2026

Merging this PR will degrade performance by 12.82%

⚡ 4 improved benchmarks
❌ 2 regressed benchmarks
✅ 119 untouched benchmarks
⏩ 9 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
findHighestSetBit[255] 47 ns 29 ns +62.07%
fibonacciBottomUp[20] 1.4 µs 1.2 µs +17.63%
fibonacciBottomUp[10] 500 ns 441 ns +13.38%
dualPivotQuickSort[100] 14.4 µs 11.1 µs +29.49%
timSort[100] 9.5 µs 10.9 µs -12.82%
timSort[1000] 149.5 µs 168.6 µs -11.34%

Comparing cod-2548-investigate-warmup-included-in-flamegraphs-in-100ns (c6a5576) with main (ff83f3b)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant