Cod 1173 build golang tests with codspeed instrumentation in runner#4
Merged
not-matthias merged 11 commits intomainfrom Aug 28, 2025
Conversation
f8a0011 to
a412fea
Compare
02935b0 to
72c9f67
Compare
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
a412fea to
0ba720d
Compare
72c9f67 to
62cce6d
Compare
507a96a to
7859c4c
Compare
62cce6d to
58ad476
Compare
f26e3f3 to
b2d863e
Compare
Contributor
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
olgtm,
watch out some commits are unverified tho
art049
reviewed
Aug 26, 2025
Member
art049
left a comment
There was a problem hiding this comment.
Looks really cool! Excited to see it working
877a3c6 to
6aac26f
Compare
6aac26f to
563e79d
Compare
a03f4dd to
55cf82d
Compare
55cf82d to
e6c78e5
Compare
art049
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation from #3 : Accidentally pushed
targetduring a rebase and let Claude fix it, which closed the PR(?)The process is split into multiple parts:
t *testing.Bparameter isn't passed to a function.cli/runner.gomain file with the benchmarks.testingto our codspeed compat packagecli/runner.goand outputs the binary.