Skip to content

Cod 1293 resolve file path inside codspeed go#12

Merged
not-matthias merged 3 commits intocod-1284-dx-improvements-for-codspeed-gofrom
cod-1293-resolve-file-path-inside-codspeed-go
Sep 2, 2025
Merged

Cod 1293 resolve file path inside codspeed go#12
not-matthias merged 3 commits intocod-1284-dx-improvements-for-codspeed-gofrom
cod-1293-resolve-file-path-inside-codspeed-go

Conversation

@not-matthias
Copy link
Copy Markdown
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-1293-resolve-file-path-inside-codspeed-go branch from 4d0c5ed to 4df13ff Compare September 1, 2025 18:53
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from daaef78 to b0d22b7 Compare September 1, 2025 18:53
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR resolves file path issues in the CodSpeed Go runner by implementing a metadata-based approach to determine Git-relative paths for benchmark files. Instead of relying on environment variables, the system now creates a go-runner.metadata file containing profile folder and relative package path information, which is then used by the Go testing framework to generate proper URIs for benchmark results.

Key changes include:

  • Implemented metadata file generation and parsing in Go testing framework
  • Modified benchmark result structure to include both name and URI fields
  • Refactored profile directory handling to be passed as parameters instead of environment variables

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
testing/testing/codspeed.go New file implementing metadata parsing and Git-relative path resolution
testing/testing/benchmark.go Updated to use metadata for file path resolution and generate proper benchmark URIs
go-runner/src/builder/templater.rs Modified to generate go-runner.metadata file with profile and path information
go-runner/src/lib.rs Refactored to pass profile directory as parameter instead of using environment variables
go-runner/src/results/raw_result.rs Updated RawResult struct to include URI field and simplified benchmark creation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread testing/testing/codspeed.go
Comment thread testing/testing/codspeed.go Outdated
Comment thread testing/testing/codspeed.go Outdated
Comment thread testing/testing/codspeed.go Outdated
Comment thread testing/testing/benchmark.go
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from 1b50d0a to c0de34e Compare September 2, 2025 08:49
@not-matthias not-matthias force-pushed the cod-1293-resolve-file-path-inside-codspeed-go branch from 4df13ff to f9ddc46 Compare September 2, 2025 08:54
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch 2 times, most recently from bc9c62e to a209282 Compare September 2, 2025 09:06
@not-matthias not-matthias force-pushed the cod-1293-resolve-file-path-inside-codspeed-go branch from f9ddc46 to 01ecfc8 Compare September 2, 2025 09:06
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 2, 2025

CodSpeed Performance Report

Merging #12 will degrade performances by 33.94%

Comparing cod-1293-resolve-file-path-inside-codspeed-go (b20d439) with cod-1284-dx-improvements-for-codspeed-go (7cd6ee5)1

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 14 untouched benchmarks
🆕 1 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkFibonacci20_Loop 70.3 µs 106.4 µs -33.94%
BenchmarkSleep100ns_Loop 1.4 µs 1.2 µs +14.85%
BenchmarkSleep1us_Loop 1.6 µs 1.9 µs -14.01%
🆕 BenchmarkExample N/A < 1 ns N/A

Footnotes

  1. No successful run was found on cod-1284-dx-improvements-for-codspeed-go (b20d439) during the generation of this report, so 3c30839 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from a209282 to 34f5844 Compare September 2, 2025 09:22
@not-matthias not-matthias force-pushed the cod-1293-resolve-file-path-inside-codspeed-go branch from 01ecfc8 to 0133765 Compare September 2, 2025 09:22
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from 34f5844 to 7cd6ee5 Compare September 2, 2025 09:51
@not-matthias not-matthias force-pushed the cod-1293-resolve-file-path-inside-codspeed-go branch from 0133765 to b20d439 Compare September 2, 2025 09:52
@not-matthias not-matthias merged commit b20d439 into cod-1284-dx-improvements-for-codspeed-go Sep 2, 2025
9 checks passed
@not-matthias not-matthias deleted the cod-1293-resolve-file-path-inside-codspeed-go branch September 2, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants