Skip to content

feat: dx improvements for codspeed go#10

Merged
not-matthias merged 8 commits intocod-1273-support-perf-in-golangfrom
cod-1284-dx-improvements-for-codspeed-go
Sep 2, 2025
Merged

feat: dx improvements for codspeed go#10
not-matthias merged 8 commits intocod-1273-support-perf-in-golangfrom
cod-1284-dx-improvements-for-codspeed-go

Conversation

@not-matthias
Copy link
Copy Markdown
Member

@not-matthias not-matthias commented Sep 1, 2025

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 1, 2025

CodSpeed Performance Report

Merging #10 will create unknown performance changes

Comparing cod-1284-dx-improvements-for-codspeed-go (b20d439) with cod-1273-support-perf-in-golang (71ed90d)

Summary

🆕 18 new benchmarks
⁉️ 17 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 fibonacci(10) N/A 560 ns N/A
🆕 BenchmarkFibonacci20_Loop N/A 70.7 µs N/A
🆕 BenchmarkFibonacci20_bN N/A 70 µs N/A
🆕 BenchmarkSleep100ns N/A 226 ns N/A
🆕 BenchmarkSleep100ns_Loop N/A 912 ns N/A
🆕 BenchmarkSleep100us N/A 100.1 µs N/A
🆕 BenchmarkSleep100us_Loop N/A 100.8 µs N/A
🆕 BenchmarkSleep10ms N/A 10 ms N/A
🆕 BenchmarkSleep10ms_Loop N/A 10 ms N/A
🆕 BenchmarkSleep10us N/A 10.1 µs N/A
🆕 BenchmarkSleep10us_Loop N/A 11.1 µs N/A
🆕 BenchmarkSleep1ms N/A 1 ms N/A
🆕 BenchmarkSleep1ms_Loop N/A 1 ms N/A
🆕 BenchmarkSleep1us N/A 1.1 µs N/A
🆕 BenchmarkSleep1us_Loop N/A 1.8 µs N/A
🆕 BenchmarkSleep50ms N/A 50 ms N/A
🆕 BenchmarkSleep50ms_Loop N/A 50 ms N/A
🆕 BenchmarkExample N/A < 1 ns N/A
⁉️ fibonacci(10) 551 ns N/A N/A
⁉️ BenchmarkFibonacci20_Loop 113 µs N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@not-matthias not-matthias marked this pull request as ready for review September 1, 2025 11:22
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from d960b2b to 5e50425 Compare September 1, 2025 11:41
@not-matthias not-matthias requested a review from art049 September 1, 2025 11:41
@not-matthias not-matthias changed the base branch from main to cod-1273-support-perf-in-golang September 1, 2025 11:42
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from 5e50425 to 2e0b691 Compare September 1, 2025 12:07
Copy link
Copy Markdown
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, don't forget to squash the fixups!

Comment thread go-runner/src/cli.rs Outdated
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from cab3584 to 2704cd1 Compare September 1, 2025 13:45
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch 4 times, most recently from 17587bb to 77dd4d9 Compare September 1, 2025 15:05
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 2704cd1 to aaebc6a Compare September 1, 2025 15:20
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch 6 times, most recently from c0de34e to bc9c62e Compare September 2, 2025 09:01
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 14a0b1b to 7aa04e5 Compare September 2, 2025 09:02
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from bc9c62e to a209282 Compare September 2, 2025 09:06
@not-matthias not-matthias force-pushed the cod-1273-support-perf-in-golang branch from 7aa04e5 to 71ed90d Compare September 2, 2025 09:21
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from a209282 to 34f5844 Compare September 2, 2025 09:22
@not-matthias not-matthias force-pushed the cod-1284-dx-improvements-for-codspeed-go branch from 34f5844 to 7cd6ee5 Compare September 2, 2025 09:51
@not-matthias not-matthias merged commit b20d439 into cod-1273-support-perf-in-golang Sep 2, 2025
18 of 19 checks passed
@not-matthias not-matthias deleted the cod-1284-dx-improvements-for-codspeed-go branch September 2, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants