fix(cli): improve error unwrapping and accept degraded health status#5
Open
BeArchiTek wants to merge 1 commit intoCloud-Temple:mainfrom
Open
Conversation
- Unwrap ExceptionGroup/TaskGroup to surface the real MCP error (e.g. HTTP 401) instead of showing the opaque wrapper - Add "degraded" to the list of accepted health-check statuses so partial-health responses are displayed correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPClient.call_toolto surface the real underlying error (e.g. HTTP 401) instead of showing the opaqueExceptionGroupwrapper. The MCP SDK uses anyio TaskGroups, which wrap failures inBaseExceptionGroup.degradedto accepted health-check statuses in the CLI so that partial-health responses are displayed correctly instead of being treated as errors.Test plan
healthcommand against a server returningdegradedstatus and verify it displays normally